Quick access to ShaderTweaks from Viewer selection #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This queries the history to find the most recent ShaderTweaks node applied to an attribute.
johnhaddon
force-pushed
the
moreHistory
branch
from
708b219
to
90ead82
Compare
|
I've squashed in some fixes so that attribute inheritance is taken into account properly. |
There have been a ton of opinions on this, and this might not be where we end up eventually, but we expect it to be an improvement over the originals as far as most folks are concerned. The main thoughts were : - `Ctrl+` shortcuts are awkward to type, so not suitable for keypresses we expect to use frequently. - `Ctrl+E` clashed with the shortcut for dispatching the selected executable nodes. - Shortcuts without modifiers can be a bit too easy to hit by accident, so may not be suitable for things that make a big change of state. We did consider using a row of ASD or HJK for various history operations, and it seems that something along these lines may be the best alternative candidate. There is an opinion that popping up a NodeEditor is too big of a state change though. - `Alt+` is easy to type, because usually you're resting on Alt for access to the camera movement. I'm sure if we ask a few more folks we'll get a few more opinions, but this is what we're going to try for now.
|
Pushed a change to the choice of keyboard shortcuts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "History/Edit Tweaks..." menu item as a companion to the recently added "Edit Source Node..." menu item. For this initial version I've gone for the simplest possible mechanism, with just a single menu item that accesses the tweaks node for the "most obvious" shader assigned at the selected location. There are other approaches we could take, such as different menu items for each assigned shader, or doing the history trace upfront (rather than when the item is chosen) and then listing nodes by name. My impression though was that folks were most interested in a single shortcut that "just works", so that's what I've tried to implement. I'm definitely happy to iterate on this and add more items/features, but my feeling is we might get better feedback if we can show something to people first...