ArnoldFilterMap : Rename to ArnoldCameraShaders and add uvRemap #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on the description, I was first picturing one input with a dropdown to select which slot to put it in, which seems like it could scale better in some ways if there were a lot of types of camera shaders. But separate input plugs is perhaps clearer. I'd say it's fine to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was originally planning on adding an ArnoldUVRemap node to allow Arnold's persp_camera.uv_remap shader to be specified in Gaffer. But it occurred to me that the name is pretty unobvious, and that ArnoldFilterMap wasn't much better in that respect. This repurposes the original ArnoldUVRemap node as an ArnoldCameraShaders node that can specify both filtermap and uv_remap shaders. If this approach seems preferable, then we should get this merged before we 0.53.2.0 (ArnoldUVRemap hasn't been released yet, so it wouldn't be a breaking change).