Arnold Toon Shader : Add metadata to improve UI. #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the NodeEditor, I tried to match the sections I saw in an online tutorial. For the nodules, I exposed the ones that seemed most likely to be used based on my limited experience with toon shading (ie. that same tutorial).
|
Also, if there is a way to apply descriptions to pages, I might apply the |
johnhaddon
approved these changes
Oct 4, 2019
|
@danieldresser-ie, do you want to comment, or can I merge? |
|
Looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the NodeEditor, I tried to match the sections I saw in an online tutorial. For the nodules, I exposed the ones that seemed most likely to be used based on my limited experience with toon shading (ie. that same tutorial).
Note the ordering in the mtd file matches what I'd like in the UI, but it seems we don't have a way to control that with metadata yet (eg layout:index) so we get a bit of a funky section ordering in the NodeEditor currently...