Add bookmarks menu to CyclesShaderUI.py #5602
Conversation
There was a problem hiding this comment.
Thanks Brian, and congrats on your first PR! I'll leave it up to you how to resolve my question about tx in the extensions list, as long as it is included one way or another.
It would be great if you could also update Changes.md to include a comment in the Improvements section, similar to the one we added when doing this for Arnold.
As it stands, this PR will be merged to main only, which means it will only appear in Gaffer 1.4. If you'd like it in 1.3 then let us know and I can rejig it appropriately.
Cheers...
John
| __metadata[paramPath]["path:leaf"] = True | ||
| __metadata[paramPath]["path:valid"] = True | ||
| __metadata[paramPath]["path:bookmarks"] = "texture" | ||
| __metadata[paramPath]["fileSystemPath:extensions"] = "exr tif tiff hdr jpg jpeg png" |
There was a problem hiding this comment.
When I did the equivalent for Arnold, I only included the tx extension, to encourage folks to use properly mip-mapped textures. Perhaps it's worth doing the same here? Or perhaps at the very least we could include tx in this list? I think Cycles uses OIIO for image loading, so if we wanted a complete list we could get it from GafferImageImageReader.supportedExtensions().
|
Thanks @johnhaddon! I updated it to use supportedExtensions() and that seems to be working well. The browser is showing jpg, exr, tx, etc now. I also added Changes.md, hope the syntax is correct. |
Following up on our earlier chat, I found that the Cycles texture file picker needed a bookmark menu as well.
|
Thanks Brian! I've merged this to the |
|
Great, thank you! I'll remember that for next time. |
Following up on our earlier chat, I found that the Cycles image texture file picker needed a bookmark menu as well.