Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diffs in SceneInspector #894

Closed
johnhaddon opened this issue Jul 2, 2014 · 4 comments
Closed

Improve diffs in SceneInspector #894

johnhaddon opened this issue Jul 2, 2014 · 4 comments
Labels
scene Issues with GafferScene

Comments

@johnhaddon
Copy link
Member

It would be great to have the character level differences highlighted rather than just the whole thing.

It seems that difflib's SequenceMatcher().get_opcodes() method might be handy here - the actual HtmlDiff class seems a bit rubbish though.

@andrewkaufman
Copy link
Contributor

It would be nice if the collapsible sections indicated that a diff exists within. So any attribute diff would result in some marking on the >Attributes label.

@johnhaddon
Copy link
Member Author

That sounds good - I was already planning on putting a summary on the section labels in the same way we have them for the Attributes and Options nodes but hadn't considered a diff there as well. Maybe just the number of common attributes in white, and the number of differing ones each way in red and green?

@andrewkaufman
Copy link
Contributor

Yeah, that sounds good to me.

@johnhaddon
Copy link
Member Author

I've split the section header bit out into #911, as it's orthogonal to this one, which was about formatting of the diff text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scene Issues with GafferScene
Projects
None yet
Development

No branches or pull requests

2 participants