Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options.transition / options.toutchTransition is ignored on touch devices #424

Open
christopherdarling opened this issue Jul 6, 2020 · 2 comments

Comments

@christopherdarling
Copy link

When leaving options.swipe to its default value (auto), on mobile/touch devices the transition effect is ignored. Setting `options.swipe = 'disabled';' seems to do the trick, but finger swiping no longer works.

Galleria version 1.6.1, theme twelve.

@dleer
Copy link

dleer commented Jul 8, 2020

That's because "touchTransition" is only referenced as a config variable.
"touchTransition: undef, // 1.2.6" in galleria.js.

It does nothing whatsoever.

I haven't figured out a way to change the native fullscreen transition. I'm not sure if/where it's configured in the code.

@christopherdarling
Copy link
Author

christopherdarling commented Jul 9, 2020

That's because "touchTransition" is only referenced as a config variable.
"touchTransition: undef, // 1.2.6" in galleria.js.

It does nothing whatsoever.

I haven't figured out a way to change the native fullscreen transition. I'm not sure if/where it's configured in the code.

I thought that initially too, but it is referenced by these lines - https://github.com/GalleriaJS/galleria/blob/master/src/galleria.js#L5239-L5248

Not tested, but fullscreenTransition should work fine from looking at that code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants