Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FmtStr does not take numbwritten bytes into account #1470

Closed
yvgny opened this issue Apr 5, 2020 · 0 comments
Closed

FmtStr does not take numbwritten bytes into account #1470

yvgny opened this issue Apr 5, 2020 · 0 comments

Comments

@yvgny
Copy link
Contributor

yvgny commented Apr 5, 2020

When executing the method execute_writes(), the numbwritten argument is not taken into account, so the written values are wrong.

Location in code:

fmtstr += fmtstr_payload(self.offset, self.writes, numbwritten=self.padlen, write_size='byte')

As suggested in #1139, a solution would be to add numbwritten to padlen so that both of the values are taken into account, but it seems that the issue was never solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants