Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #42

Open
RyanGlScott opened this issue Apr 24, 2023 · 3 comments · May be fixed by #62
Open

Add CI #42

RyanGlScott opened this issue Apr 24, 2023 · 3 comments · May be fixed by #62
Labels
ci Continuous integration

Comments

@RyanGlScott
Copy link
Contributor

We should add a basic CI setup that ensures that everything builds as expected.

@RyanGlScott RyanGlScott added the ci Continuous integration label Apr 24, 2023
@langston-barrett
Copy link

It would also be nice to publish pre-built binaries, considering that the build requires a very specific version of the Rust toolchain that users are unlikely to have installed.

@langston-barrett langston-barrett linked a pull request Nov 28, 2023 that will close this issue
@RyanGlScott
Copy link
Contributor Author

I haven't thought much about publishing binary distributions, but one complication that I foresee is that mir-json's binaries are implemented as rustc/cargo plugins. My understanding is that plugin-based tools are intimately tied to the particular toolchain used to build them, and as a result, I'm unclear if you could simply download and run mir-json without having the parent toolchain already installed. (I could be wrong on this, however—I haven't tried to see what would happen.)

@spernsteiner
Copy link
Collaborator

I'm unclear if you could simply download and run mir-json without having the parent toolchain already installed.

You do need the parent toolchain. The various mir-json binaries link against that toolchain's specific versions of libstd-xxx.so and librustc_driver-yyy.so.

I believe Kani handles this by shipping the toolchain itself along with their binaries that depend on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants