-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sublime plugin async #194
Comments
That's cool! I like how it doesn't have any external dependencies. That's one bad thing about import-js, it will require you to know a little about Ruby (or at least know how to use Ruby gems). The reason for that is that import-js started out as a vim-only plugin. Vim has built-in support for Ruby, and I myself is most familiar with writing libraries in Ruby. I don't know if they could be easily merged however. They seem to solve the problem slightly different. But there are probably things we can learn from each other. For once, it looks like your Sublime plugin is asynchronous, is that correct? I never got around to doing that for the Sublime plugin for import-js. It would be interesting to know what problems you ran into, and also to see if you still run into them today. I understand if that's hard though, often you try something out until you hit too many issues and then just say f it... However, there have been a lot of changes done to import-js lately to support even more project layouts and environments. It would be fun if you would give the latest version a spin! If you are interested in helping out more over here (yay, do it! 😄), I would be thrilled if you could make any improvements to the import-js Sublime plugin and how it uses the If you're looking for enhancements to make to your own plugin, here are a few suggestions:
Again, thanks for joining forces on this! |
Yes, I want to help! I will give a look at the code again and test the new version. The idea of "merging" these plugins was about getting some ideas, like The main idea of The problem was when I had to do something asynchronously in a specific import the whole process was messed up. So I divided it on parts.
Then, a selection would be only written if every import of it was resolved. If an async request is made for an import, the Selection Object that stores this import will not be resolved until this request is done. I don't know how its done in The problems I was having were some Ruby errors while running the plugin, I've never used Ruby so I think i have done something wrong while installing it :p. But I was also using a very young version of Another idea I have is to make it not only for js. It can me reused for other languages, like python. We just have to change how it is written, because the ideia of variable and module is the same. Thanks to you, may the force by with us! |
Love this! 👍 |
I changed the title of this issue so that it's more actionable. |
Sorry for taking so long to reply on this issue, I was working on two projects ( only one now ) and I had no time to give a look on the code. I will give it a look and try to help as much as I can. |
This issue was moved to Galooshi/sublime-import-js#1 |
Hey, how are you doing? Some time ago, I've tested this plugin and I ran into some problems. I created an issue and I was encouraged to change some little things on the code, that later on fixed my problem. This inspired me to create my own plugin, since I was having other problems.
I'm using
simple-import
a lot and I thought that maybe you could incorporate some things ofsimple-import
intoimport-js
. I'm really into React development with ES6 so I was not usingimport-js
because I know nothing about ruby and, until the version I was using, it didn't have animport
like ES6.It`s a 470 lines python file. If you have some time to have a look I appreciate.
https://github.com/vini175pa/simple-import-js
The text was updated successfully, but these errors were encountered: