Test suite and BF for SRS CTC-100 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full coverage test suite for SRS CTC-100 Minor bug fix for `srsctc100.py`: `get_log_point` method in `Channel` subclass assigned a quantity to return values without converting them to numbers. Returned were thus unitful strings. While technically not a bug, this behavior does not fit together with the rest of this class or the general returns in ik Now floats are returned.
|
@scasagrande I think the usage of parametrization and |
|
Back to the computer. Tests look great to me! |
scasagrande
reviewed
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full coverage test suite for SRS CTC-100
Minor bug fix for
srsctc100.py:get_log_pointmethod inChannelsubclass assigned a quantity toreturn values without converting them to numbers. Returned were thus
unitful strings. While technically not a bug, this behavior does not
fit together with the rest of this class or the general returns in ik
Now floats are returned.