Refactor of PR #56 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into CatherineH-ch-tc200
| if ack_expected is not None: | ||
| ack = self.read() | ||
| if ack != ack_expected: | ||
| raise IOError("Incorrect ACK message received: got {} " |
There was a problem hiding this comment.
I should make new errors called AckError and PromptError or something. Thoughts what the correct base they should inherit from @cgranade ?
| def __init__(self, stdin=None, stdout=None): | ||
| AbstractCommunicator.__init__(self) | ||
| self._terminator = '\n' | ||
| self._stdout = stdout | ||
| self._stdin = stdin | ||
|
|
||
| ## PROPERTIES ## |
There was a problem hiding this comment.
just curious - does removing this extra pound sign mess up the sphinx docs?
There was a problem hiding this comment.
Nope, they were just there to look pretty when looking at the source, but pylint likes to complain about them.
I might disable that rule in a .pylintrc file because I kinda like the ## for visual distinction
But then again I'm lazy and I use autopep8 and its removing it anyways soooooo
|
I think we're good now with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ack_expectedfunction">") after finishing with a previous commandRegarding ack and prompt strings, here is the assumed format:
Sending a command:
CMD=1returns[ack][term][prompt][term]Sending a query:
CMD?returns[ack][term]response term[prompt][term]