Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To do list branch #1

Merged
merged 20 commits into from Sep 22, 2021
Merged

To do list branch #1

merged 20 commits into from Sep 22, 2021

Conversation

Gambit142
Copy link
Owner

I created a website that dynamically displays tasks to be done in a day using Webpack and ES 2015 The following were done to meet the project requirements:

  • Configure linters to ensure that there are no errors
  • Documentation of work in a professional manner
  • Use of correct Github flow

All specific project requirements enlisted below were implemented in this branch:

  • Setting up of project with Webpack
  • Using an index.html template file through HTML Webpack Plugin
  • Create an index.js file and set an array of objects that contains the following keys:
    • description [string].
    • completed [bool].
    • index: [number].
  • Use a function to iterate through the array and render the dynamically created list of tasks in the placeholder created in the index.html file
  • The list of tasks should appear in order using the index value
  • Create a style.css file that must be loaded using Webpack Style/CSS Loader
  • All your source files (index.html, index.js and style.css) must be located in_/src_directory and your distribution files will be generated by Webpack and served by webpack dev server from /dist folder.

…be displayed dynamically in the index.js file
… project resemble that of minimalist template
Copy link

@AshakaE AshakaE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Gambit142 🙋‍♀️,

STATUS APPROVED ✔

Good job on the pull request 👍
Readme is great but please work on the live demo link 👍
Your project is complete! There is nothing else to say other than... it's time to merge it 🔗 🚢
Congratulations! 🎉

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers 🥂 and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Gambit142
Copy link
Owner Author

Thank you for the feedback, I will certainly work on the live demo link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants