Add ETF Report functionality from The Passive Investor #857
Conversation
There was a problem hiding this comment.
Another thing is the export capability of your package. I think you relied on Windows using "" but for Unix you need to use "/". The way to handle this is to avoid adding "" or "/" to the folder location and use os.path.join(folder, filename). This command recognises the operating system and uses the appropriate slash
| @@ -73,6 +76,9 @@ def print_help(self): | |||
| gainers show top gainers | |||
| decliners show top decliners | |||
| active show most active | |||
|
|
|||
| The Passive Investor: | |||
| report create report of multiple tickers | |||
There was a problem hiding this comment.
Can we call this command "pir" or similar, to mention passive investor report, just because we use "reports" for the customisable one and to be easily distinguishable
| ) | ||
| print( | ||
| f"Created ETF report as {ns_parser.filename}.xlsx in folder {ns_parser.folder}" | ||
| ) |
There was a problem hiding this comment.
Can you add a new line here "\n"
|
Made the changes, updated thepassiveinvestor to 1.0.9 to make it robust for Windows and Linux/Apple. @DidierRLopes |
Super!! Thank you! Once the checks pass, I'll merge this baby 😄 |
Added functionality for creating ETF Reports via ThePassiveInvestor. By default it exports the file to /exports/etf but you can decide your own location with --filename and --folder (or simply include the full path in --filename).
Re-created this Pull Requests because I had issues with CRLFs and LF. This seems to be fixed now :)
Example report: ETF_report_20211022_201731.xlsx