Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download world button does not download a valid .zip file #116

Open
CoWinkKeyDinkInc opened this issue Mar 30, 2020 · 5 comments
Open

Download world button does not download a valid .zip file #116

CoWinkKeyDinkInc opened this issue Mar 30, 2020 · 5 comments
Labels

Comments

@CoWinkKeyDinkInc
Copy link

CoWinkKeyDinkInc commented Mar 30, 2020

I clicked on the download world button while the Minecraft server was turned off, and once it finished downloading I tried to open it up in Ark, and it says the file is not actually a zip archive. I copied it over to another computer and tried opening it using macOS Archive Utility and that also fails. I know about using the scp command to download a copy using that so I am fine, as that downloads a legitimate copy

@Raekye
Copy link
Member

Raekye commented Apr 2, 2020

I'll have to look into this. Thanks for letting me know

@Raekye
Copy link
Member

Raekye commented Apr 2, 2020

This is hopefully fixed in the minecraft server wrapper (it now uses shutil.make_archive).
I tested the zips on both windows and linux.
Please let me know if the problem persists - otherwise I will close this in a weak.

Thanks!

@mbainter
Copy link

mbainter commented Apr 2, 2020

Unfortunately it still doesn't work for me. I just started up mine, stopped minecraft, took a backup, and downloaded the zip:

$ unzip -t minecraft-world-2020_apr_02.zip 
Archive:  /home/mbainter/Downloads/minecraft-world-2020_apr_02.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /home/mbainter/Downloads/minecraft-world-2020_apr_02.zip or
        /home/mbainter/Downloads/minecraft-world-2020_apr_02.zip.zip, and cannot find /home/mbainter/Downloads/minecraft-world-2020_apr_02.zip.ZIP, period.

$ file minecraft-world-2020_apr_02.zip 
/home/mbainter/Downloads/minecraft-world-2020_apr_02.zip: Zip archive data, at least v2.0 to extract

7z also gives me:

ERRORS:
Unexpected end of archive

But, as before it's fine on the server itself:

$ unzip -t minecraft-world_backup-2020_04_02-18_11_05-763304.zip 
Archive:  minecraft-world_backup-2020_04_02-18_11_05-763304.zip
    testing: session.lock             OK
...
    testing: region/r.2.-2.mca        OK
No errors detected in compressed data of minecraft-world_backup-2020_04_02-18_11_05-763304.zip.

Downloading via SCP it works fine -- it's just when using the Download button in the UI that something isn't right.

@Raekye
Copy link
Member

Raekye commented Apr 2, 2020

Hmmm, I just tested on Chrome (previously on Firefox), and it seemed ok for me, not using 7zip though. If you have a chance, could you run grep make_archive /opt/gamocosm/mcsw.py on your server, and let me know if it prints anything? The setup_server_worker.rb should update the minecraft server wrapper every time it boots, but that could hasn't been exercised in a long time (haven't made changes to the server wrapper for a while)

@Raekye
Copy link
Member

Raekye commented Apr 9, 2020

I'm having trouble reproducing this, I've tried on:

  • Windows, Firefox
  • Linux, Firefox
  • Mac, Firefox
  • Mac, Chrome

I'm assuming some people are still having this issue. If you could report:

  • Your OS
  • Browser
  • If you can SSH, the output of grep make_archive /opt/gamocosm/mcsw.py (I want to see if MCSW got updated properly)

Many thanks

@Raekye Raekye added the bug label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants