Skip to content
This repository has been archived by the owner on Nov 10, 2019. It is now read-only.

Text fields in Plugin and Description lose focus after one character #48

Closed
Sasha-alTherin opened this issue Aug 21, 2016 · 10 comments
Closed

Comments

@Sasha-alTherin
Copy link

Text field inputs at levels below GROUP loose their focus after a single character. Causing one to re-click on the text field to enter the next character. Fields tested were the Plugin name and the plugin's Description.

Context

In testing out the latest stable version, I attempted to re-create an existing FOMOD installer of one of my mods. I had my original XML open in Notepad++ so that I could view portions of it while seeing what FOMOD-Designer has to offer. While I can copy & paste text just fine, I was trying to type directly into the text field as I would in a brand new FOMOD installer write up.

Process

  1. Select Config in Node Tree
  2. Add Name under Children Box and type in name in Property Editor
  3. Add an Installation Steps
  4. Add an Installation Step and type in name
  5. Add an Option Group
  6. Add a Group and type in name
  7. Add Plugins
  8. Add a Plugin and try to type in the name
  9. Add a Description and try to type in the description

Expected result

Expected to be able to type what I needed to without having to continually re-click on the text field

Current result

When I reach the Plugin name field I type one letter, scratch my head when I see that the rest of the word did not appear. Click text field again, type another letter, get frustrated that my word is not typing. Continue to click and type repeatedly until finished. Move on to the Description field and try to type in it. Get fed up and copy & paste from another source.

Possible Fix

No idea

name of issue screenshot

No screenshot

@Sasha-alTherin
Copy link
Author

Addendum:
Seems to affect all text fields after having entered text for ModuleName, InstallationStep and the first Group name. Having moved on to the next Group, I can only type one letter at a time. For what it is worth, this has all been in one session. No idea if it will behave differently when I save and reopen. That will be my next test.

Also, forgot to mention, I am testing the 64 bit version.

@GandaG GandaG added the bug label Aug 22, 2016
@GandaG GandaG self-assigned this Aug 22, 2016
@GandaG
Copy link
Owner

GandaG commented Aug 22, 2016

I can't reproduce the issue, can you check if the focus goes to another widget? (another text field for example)

@Sasha-alTherin
Copy link
Author

I think I see what is going on. I am typing directly into the box that is in the property editor rather than clicking on the ... button and typing in the box that pops up. Was not aware that it would pop up a box for entering text till I tried to use it to get a dependent file for a pattern.

Perhaps that button should be labeled in a way that indicates what it should be used for.

@GandaG
Copy link
Owner

GandaG commented Aug 22, 2016

You can type in the box, that is what it is meant for. As you can see here, it works fine, still can't reproduce. Do you have any recommendation for the label?

@Sasha-alTherin
Copy link
Author

No idea for a label. Text Editor doesn't work since there are no editing features. Its just a large text input box.

Here is a video showing what is happening. I changed the Preview Refresh Rate to On Node Select from On Property Editing but it is still refreshing with each letter. This was done to see if the refreshing was causing the text box to lose focus. Did not help.

Other than this, the tool was able to re-create my original FOMOD. If I need to make another FOMOD, I will probably turn to this tool.

I will download and try the 32 bit version.

@GandaG
Copy link
Owner

GandaG commented Aug 22, 2016

The text editor boxes are for larger texts. There are no editing features since those attributes do not support them. If you want to see an example of simple html editing, see the Description node's text box.

The refresh rate is definitely a bug, please post a separate issue for it (just something simple).

As for the loss of focus I'll look into it but since I can't reproduce I'm going to be shooting blind.

@Sasha-alTherin
Copy link
Author

More information, maybe you won't have to shoot too blindly:
My initial use of the tool was to see if it would load my existing FOMOD (the one I had open in Notepad++). Pointed the utility to my project folder, but the FOMOD was not loaded. It gave me a blank slate so I recreated the FOMOD using the old one as a guide.

The presence of the pre-existing FOMOD and/or it being loaded in Notepad++ must have caused the issue. Closing Notepad++, removing the old and the new FOMOD files, however, did not alleviate the issue. The issue did not disappear until I cleared all listings for recently opened projects.

At this point, so long as I use a mod project that does not have any pre-existing FOMOD related content, there are no issues with the text input fields. My best guess, my self-created FOMOD must have lacked something that your utility expected and thus created a problem somewhere that manifested itself in the text fields.

I do remember your utility wanting to add a "type" entry under "pattern" that I did not have in my original FOMOD. The original had worked with only having a "defaultType" entry under "dependencyType". Perhaps because of that, my FOMOD wouldn't load and corrupted the tool so long as the original instance of that project was stored in the recent files.

@GandaG
Copy link
Owner

GandaG commented Aug 22, 2016

I do remember your utility wanting to add a "type" entry under "pattern" that I did not have in my original FOMOD.

Even if the FOMOD is not valid it should load just fine. I'll look into it too.

I'm not sure how Notepad++ does it, but I'm pretty sure they store a buffer of the file itself (this don't, it just store paths) which may lead to the file being held hostage by NP++ which may lead to weird behaviours. Maybe it was constantly trying to load?

In that process, did you ever restart the Designer?

@Sasha-alTherin
Copy link
Author

Not until after I finally completed the FOMOD which was after making the first post. I restarted to see if that would take care of the refresh issue and the text field issue. After that, I did a lot of restarting of Designer both 32-bit and 64-bit with and without Notepad++ running as well as with the original mod project and different mod projects. The video I posted was in the middle of all the various restarts.

I was going to go radical and delete the .designer file in the .fomod folder under my user folder but then I tried just cleaning out the recent files and that worked. Was able to point to a mod project folder whose FOMOD information was removed and went through the designer setting up multiple groups and plugins without any text issue.

At any rate, Notepad++ prompts you if you want to reload the file or keep the current contents should the file be changed in another program. It only prompts when Notepad++ regains focus. I'm not sure how it could lock it up, but I'm a user not a programmer.

@GandaG
Copy link
Owner

GandaG commented Aug 26, 2016

Added a check in 7b80914. If the issue comes up again feel free to re-open!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants