use transmute for ptr.addr #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Miri CI should pass after the next nightly is released. |
|
i'm a bit underwater with my actual work, i've invited you to be a collaborator on the repo and an owner of the crate so that you can do this stuff unilaterally when you need to |
|
Ah, fair. I'll merge these PRs but I don't think I will do a release until someone asks for it, that seems a bit scary.^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs with rust-lang/rust#97710
Once rust-lang/miri#2133 is complete, this then correctly implements the distinction between
addrandexpose_addr, as well as betweeninvalidandfrom_exposed_addr. Misuses of these APIs are detected by Miri, and ptr-int-ptr roundtrips only work if you useexpose_addrandfrom_exposed_addr. :)