New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed SDL related header includes for linux #1212
Conversation
Thanks for the fix! Glad to hear of people working in Linux. Did you manage to get everything working after this? |
We need to do some work for a stable linux version... but we are on the way :) Not sure why other ppl dont have this problem on Ubuntu and VM. |
@LuisAntonRebollo merge if it looks good! |
Unfortunately I have not been able to get everything working yet.
From then on I receive many many |
Interesting. So not using CMake? Any luck following instructions similar to this? |
Sorry for the late reply. At first I followed the steps of the readme at github so I just used make. |
I'm working on updating the readme and github wiki to have the latest information - the previous method is a little old, though it's weird that it doesn't work any more 😂 |
I don't know if you are interested in updating the wiki for fedora as well? |
Awesome! Which version of Fedora do you think is a reasonable compatibility indicator? I've added the instructions to this page. |
@pbrand is this change required for you when using CMake to compile? For me, this breaks compiling with |
Regarding your question about which version of Fedora is a reasonable compatibility indicator. I tried to build this project under Fedora 21 (latest stable release at this moment) and Fedora 20 and both were successful. |
I had problems when using CMake too. However it would be strange to address that to the includes, as some of the other classes already used the |
Heh, that's definitely not on purpose - feel free to raise a separate issue about it. Indeed, the OpenGL driver should be selected. Hmm, I wonder why the |
So even after the rebase you still experience problems? |
Yeah, bizarrely the |
Okay, make (still) doesn't work for me either, just CMake -> ninja works for me. |
Okay, got it. Strange. My setup has been causing issues a bit recently, in cases where CI is fine. Not sure if it's because our CMake setup is only tested using ninja/clang or what. I'll have a chat to some of the other SC members about it. My setup appears to be more pedantic, so I'm not convinced it's wrong... but it's still bizarre, especially in this case. |
By the way, I just noticed something for the 'Build using Qt Creator' section of the wiki. |
That section is somewhat incomplete just FYI, but thanks, I'll add a note about that. |
I get errors, compiler can't get SDL headers :(
It's posible those I think those changes make T3D to search on OS libraries instead of T3D lib folder. @pbrand, you can compile with CMAKE without this changes? |
Yes, it works fine if I compile the code of your development branch with CMAKE. |
Old linux instruction are for DEDICATED build.. used only for game servers. Sorry we are a bit in the middle of the change :P |
When trying to compile the development branch on Fedora 21 (x86_64) I ran into the following error:
This micro contribution fixes the the SDL related header includes, so that the previously mentioned fatal error is resolved. This way the inclusion of SDL related headers is consistent with the the includes of these headers in other classes of this directory as well.