Allow other lookups in ModelInstance
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulope
force-pushed
the
model_instance_lookup
branch
from
70b41c6
to
6cc0754
Compare
|
Looks good as well, but could you please rebase it on master? P.S.: I wrote exactly the same change today (albeit on a different project with a backported |
This makes `ModelInstance` accept a keyword argument `lookup` (that defaults to 'pk') which allows to specify which lookup to use on the given `QuerySet`.
ulope
force-pushed
the
model_instance_lookup
branch
from
6cc0754
to
10284ab
Compare
Done.
Funny how often that happens :) |
| DummyModel.objects.create(slug='test') | ||
| expected = b'<DummyModel: 1>' | ||
|
|
||
| assert call_command('modelcmd', '--pk', '1').stdout == expected |
There was a problem hiding this comment.
This is a bit fragile (e.g. when using --reuse-db), as the ID could change across runs. Would be better to use instance = DummyModel.objects.create(slug='test') and instance.pk.
|
Thanks for the PRs. I added this commit 6aeeb7b and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ModelInstanceallows lookups only bypk. This PR adds support for arbitrary lookups by adding alookupkeyword argument.Example:
@clik.option('--something', type=ModelInstance(SomeModel, lookup='name'))(This PR is intended to be merged on top of the changes from #2 )