Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for currencies besides USD #8

Open
Gbox4 opened this issue Jan 19, 2022 · 2 comments
Open

Add support for currencies besides USD #8

Gbox4 opened this issue Jan 19, 2022 · 2 comments

Comments

@Gbox4
Copy link
Owner

Gbox4 commented Jan 19, 2022

The currency will always be displayed as USD, even if the data is from a foreign market of a different currency. Additionally, it will be displayed as USD even if it is a unitless measure, like an index.

@Gbox4
Copy link
Owner Author

Gbox4 commented Jan 24, 2022

This issue has been fixed for crypto and forex. However, there is still the problem of displaying a dollar sign $ for international markets, where the prices may be a different currency. I believe the alphavantage return data includes the currency.

@Gbox4
Copy link
Owner Author

Gbox4 commented Feb 18, 2022

The metadata does not include the data. Only solution I've found so far is to either a) hard code a dictionary with exchange-currency pairs or b) query the API's search function for additional information about the stock. But then the program would be making 2 API calls. I suppose I could implement multithreading and send both API requests at once. I'll figure it out I guess. But for the time being I simply removed the dollar sign when the ticker has a . in it: d247eeb

@Gbox4 Gbox4 closed this as completed Feb 18, 2022
@Gbox4 Gbox4 reopened this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant