Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up the files and changed the installation script #2

Merged
merged 3 commits into from Dec 26, 2021

Conversation

mina-atef-00
Copy link
Contributor

  • Fixed a typo in the README. 80298c1
  • Added visual studio code and python files to ./.gitignore to remove the cache files. 88e8f98

Installation Script Changes: 3099416

  • Requires running with sudo using sudo bash install.sh to copy to /usr/local/bin/
  • Exits on command errors showing which command exited with error.
  • New Script Output (doesn't show pip output):
❯ sudo bash "install.sh"
[sudo] password for pure-cheekbones: 
Installing package requirements...
Installing package...
Cleaning up...
Package Installed! 

Please add this line to your shell profile (You are using /bin/bash):
'export WEATHER_CLI_API=<your OWM api key>'

@Gcat101
Copy link
Member

Gcat101 commented Dec 26, 2021

Seems good to me, thanks for your contribution.

@Gcat101 Gcat101 merged commit d6eb40f into rainbow-sh:master Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants