-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modules unsupported and more... #1
Comments
My thoughts as well, I was happy to find this plugin for Nativescript, but disappointed that it doesn't support Modules, which makes it unusable for me. |
@MagnusJohansson:
This seems to be a good solution as that package is well maintained / used. Hope this helps everybody! |
First, thanks for writing this plugin it is exactly what I need (well see below)!
This does not allow modules however to be utilized as the vuex-persistedstate package does. When specifying them in the array similar to myModule.stateName NativeScript dies with ReferenceError: myModule is not defined even though it is specified in the modules section of the store. The ReferenceError goes away if the variable are enclosed in quotes like 'myModule.stateName', however it does not seem to be persisting the module states still..
I suspect I can add this to the module and it will work, but only for ONE module. This is because it uses a static key (ns-vuex-persistant) for the local storage. First, the spelling of "persistent" in the key is wrong and that can be fixed. Second, can you allow an option on creation to specify the key and use default values if one is not passed? This would allow each module to persist its own values on their own. The other option of course is get modules working at the top level.
Thanks!
The text was updated successfully, but these errors were encountered: