Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination to gateway getting #32

Merged
merged 1 commit into from Mar 23, 2022
Merged

Add pagination to gateway getting #32

merged 1 commit into from Mar 23, 2022

Conversation

RobertLucey
Copy link
Contributor

When there are many gateways on an account / region and the relevant
ones aren't on the first page (25 per page) they start to accumulate since
they may not be found to be deleted.

@RobertLucey
Add pagination to gateways
6e7fc85 
When there are many gateways on an account and the relevant ones aren't
on the first page (25 per page) they start to accumulate since they are
not deleted
@Ge0rg3 Ge0rg3 added bug Something isn't working help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Mar 15, 2022
@Ge0rg3
Copy link
Owner

Ge0rg3 commented Mar 15, 2022

Thank you! Will test this and merge shortly 😄

@Ge0rg3
Copy link
Owner

Ge0rg3 commented Mar 23, 2022

Hi @RobertLucey, do you reckon this change makes more sense? powertohack@e695445

@RobertLucey
Copy link
Contributor Author

Hey @Ge0rg3,

There's 2 things that may not be right about that change

  1. According to https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/apigateway.html#APIGateway.Client.get_rest_apis the maximum limit value is 500.
  2. Capping at any large number will work for most anyone since the default aws limit on the number of gateways you can have without requesting more is 600 (I think). Iterating through the pages would be the only way to be sure to get them all

@Ge0rg3 Ge0rg3 merged commit 3a47b5a into Ge0rg3:main Mar 23, 2022
@Ge0rg3
Copy link
Owner

Ge0rg3 commented Mar 23, 2022

Great, thanks for the insight here! This will be rolled out in the next release, probably ~1mo ❤️

Ge0rg3 referenced this pull request in powertohack/requests-ip-rotator Mar 23, 2022
@ralamosm
adding larger limit to get_rest_apis to get previously created ones
e695445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RobertLucey @Ge0rg3