-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI is lacking coverage of previous rustc versions and feature flag combinations #500
Comments
It was actually f996485 which introduced the deprecated annotation. |
so, now, since |
I wouldn't personally consider this fixed since it's still a regression on the 2.x line. If you don't want to push fixes to previous major version branches I can understand that though. @Geal there's still an underlying issue that 'nom' is not properly ci testing with previous 'rustc' versions, so this is likely to happen again. |
Also noticed from a quick look at .travis.yml that the three ENV declarations seem to be overwriting each other. I think they need to be defined in a 'matrix'. |
Nom 2.2.x requires rustc 1.9.0 due to a deprecated annotation. Nom 2.0.0 passes the test suite with rustc 1.8.0. The travis configuration appears to be targeting rustc 1.2 and passes, so there is almost certainly something wrong with the CI setup.
The text was updated successfully, but these errors were encountered: