Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is lacking coverage of previous rustc versions and feature flag combinations #500

Closed
danburkert opened this issue Apr 29, 2017 · 4 comments · Fixed by #634
Closed

CI is lacking coverage of previous rustc versions and feature flag combinations #500

danburkert opened this issue Apr 29, 2017 · 4 comments · Fixed by #634
Milestone

Comments

@danburkert
Copy link

Nom 2.2.x requires rustc 1.9.0 due to a deprecated annotation. Nom 2.0.0 passes the test suite with rustc 1.8.0. The travis configuration appears to be targeting rustc 1.2 and passes, so there is almost certainly something wrong with the CI setup.

@danburkert
Copy link
Author

It was actually f996485 which introduced the deprecated annotation.

danburkert added a commit to danburkert/procinfo-rs that referenced this issue Apr 29, 2017
danburkert added a commit to danburkert/procinfo-rs that referenced this issue Apr 29, 2017
danburkert added a commit to danburkert/procinfo-rs that referenced this issue Apr 29, 2017
@Geal
Copy link
Collaborator

Geal commented May 15, 2017

so, now, since chain! has completely disappeared, the annotation was removed too, so I guess I can close this issue :)

@Geal Geal closed this as completed May 15, 2017
@danburkert
Copy link
Author

I wouldn't personally consider this fixed since it's still a regression on the 2.x line. If you don't want to push fixes to previous major version branches I can understand that though.

@Geal there's still an underlying issue that 'nom' is not properly ci testing with previous 'rustc' versions, so this is likely to happen again.

@Geal Geal reopened this Jul 27, 2017
@danburkert
Copy link
Author

danburkert commented Jul 27, 2017

Also noticed from a quick look at .travis.yml that the three ENV declarations seem to be overwriting each other. I think they need to be defined in a 'matrix'.

@danburkert danburkert changed the title nom 2.2.x requires rustc 1.9.0 CI is lacking coverage of previous rustc versions and feature flag combinations Jul 27, 2017
@Geal Geal added this to the 3.3 milestone Sep 6, 2017
@Geal Geal closed this as completed in #634 Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants