Implement seeking to the end of the content in a MemProducer #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Could you add unit tests? With one testing the underflow. To make sure I won't introduce regressions :) |
|
No problem :). I've added tests for seeking backwards within the buffer and beyond start and end |
Geal
added a commit
that referenced
this pull request
Aug 25, 2015
Implement seeking to the end of the content in a MemProducer
|
great, thanks! By the way, may I ask which format are you parsing with nom? Please notify me on #14 when it is done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm currently building a parser for the old Apple/OpenStep binary property list format and that needs to seek to the end of the archive to find some bookkeeping information. To make it easier for testing, I've implemented support for SeekFrom::End in the MemProducer.
Please have a look whether this makes sense to you. Thanks!