Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spurious "ok" printed by syslog::init() #39

Closed
semenzato opened this issue May 20, 2018 · 4 comments
Closed

spurious "ok" printed by syslog::init() #39

semenzato opened this issue May 20, 2018 · 4 comments

Comments

@semenzato
Copy link

This code:

      syslog::init(syslog::Facility::LOG_USER,
                     log::LevelFilter::Warn,
                     Some("memd")).expect("cannot initialize syslog");

prints "ok" on the console. Thanks!

"checksum syslog 4.0.0 (registry+https://github.com/rust-lang/crates.io-index)" = "7e5efafb659e873387a9a0e793a09dee1df860c377a54cfecb4af5715d8d51f1"

@ckauhaus
Copy link

ckauhaus commented Jul 4, 2018

This is really annoying. Looks like left-over debugging println!()'s in lib.rs L197 and L205. Please remove and release a bugfix version asap!

@richardwhiuk
Copy link

rust-syslog/src/lib.rs

Lines 197 to 205 in 5867edc

println!("ok");
Ok(Logger {
formatter: formatter,
backend: LoggerBackend::Unix(sock),
phantom: PhantomData,
})
},
Err(ref e) if e.raw_os_error() == Some(libc::EPROTOTYPE) => {
println!("testing stream");

Should be pretty easy to change these to either debug macros, or just remove them entirely.

@daboross
Copy link

There's a PR for it at #38.

@Geal
Copy link
Owner

Geal commented Aug 27, 2018

syslog 4.0.1 is released with those println removed

@Geal Geal closed this as completed Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants