Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morning session review 20/05/2022 #4

Open
EidHachem opened this issue May 20, 2022 · 0 comments
Open

Morning session review 20/05/2022 #4

EidHachem opened this issue May 20, 2022 · 0 comments

Comments

@EidHachem
Copy link

Hello @GedeonTS, You did a great job implementing the requested requirements for this project, below you can find few comments on how you can improve the functionality of the website:

  • It is better to notify the user with an alert or a popup if the input fields were not filled with data
  • Try to add conditions to the inputs value to make sure that only valid usernames are accepted.

I have to mention that the design and the responsiveness of the website are really good added features.

Nice work 👏🏽 👏🏽 👏🏽

Happy Coding 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant