Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to count comments on a movie #29

Merged
merged 1 commit into from May 21, 2022
Merged

Conversation

Lembani
Copy link
Collaborator

@Lembani Lembani commented May 21, 2022

This PR contains Tests for a comment counter.

Highlights:

  • Add a mock for comments
  • Test to count the number of comments on each movie.

Your review is welcome. 😃

Copy link
Owner

@GedeonTS GedeonTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 💯 ✅ 🥳 🎈 🎉

Hi @Lembani , 👋🏻

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

(Highlights) Good points

The test is working perfectly.
There are no linters errors
The pull request is following the Github workflow.
There are no YAGNI, and KISS issues.

Cheers and Happy coding!👏👏👏

@Lembani Lembani merged commit df4b7d7 into dev May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants