Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.15.2] Server crash when looking at a watermellon stock #9

Closed
ProsperCraft opened this issue Mar 11, 2020 · 5 comments
Closed

[1.15.2] Server crash when looking at a watermellon stock #9

ProsperCraft opened this issue Mar 11, 2020 · 5 comments
Labels
1.15.2 bug Something isn't working

Comments

@ProsperCraft
Copy link

Describe the bug
When you look at a watermelon stock the server crashes, remove LAT and it no longer crashes.

Crash report -
https://gist.github.com/ProsperCraft/927144a392a72e38c08aab92cca7a6e7

From mod author chat in my discord -

kwpugh: the StemBlock.func_176481() is old mappings, current mappings have it as
@nullable
@onlyin(Dist.CLIENT)
protected Item getSeedItem() {
if (this.crop == Blocks.PUMPKIN) {
return Items.PUMPKIN_SEEDS;
} else {
return this.crop == Blocks.MELON ? Items.MELON_SEEDS : null;
}
}

@Tom-The-Geek
Copy link
Owner

This issue is similar to #7 and I am looking into the issue as it appears to be a bug with Forge's SAS overrides.

@Tom-The-Geek
Copy link
Owner

Tom-The-Geek commented Mar 13, 2020

Also, the note about new/old mappings mean nothing in a runtime environment as function names are not deobfuscated and so the MCP names are used. This means that the bug is caused by sidedness and not outdated mappings on the mod.

@Tom-The-Geek Tom-The-Geek added 1.15.2 bug Something isn't working labels Mar 13, 2020
Tom-The-Geek added a commit that referenced this issue Mar 18, 2020
@Tom-The-Geek
Copy link
Owner

Implemented temporary fix for this and will push to CurseForge tomorrow.

@Tom-The-Geek
Copy link
Owner

Forge appears to have fixed the issue in MinecraftForge/MinecraftForge#9114bec. When Forge releases the version containing this fix, I will close this issue.

@Tom-The-Geek
Copy link
Owner

Forge has fixed in 1.15.2-31.2.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.15.2 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants