Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more styling options #38

Merged
merged 6 commits into from May 29, 2022
Merged

Add more styling options #38

merged 6 commits into from May 29, 2022

Conversation

felixgabler
Copy link
Contributor

Hi! I extended the styling options a bit and fixed some minor issues:

  • When calling setState after an async call, it is important to check whether the widget is still mounted
  • Now, there is both a vertical and a horizontal positioning to offer a bit more control
  • I also added an offset parameter to move the box around (can be used to achieve the same positioning as what you had with TOP positioning before which seemed a bit arbitrary, fixes Top Position isn't on top of ReactionButton #20)
  • Users can now specify what spacing they want to add between their reactions
  • Updated dependencies, adapted something for Flutter 3 and removed an autogenerated local file from git (fixes Flutter 3.0.0 is detecting issue with the library #36)

Please do let me know if I should change anything

@felixgabler
fix: prevent unmounted setState
63b41a6
@felixgabler
feat: slightly rework positioning to allow more fine grained control
edc4801 
- add horizontal positioning
- allow specifying offset of box after positioning
- make TOP and BOTTOM exactly the same and provide backward compatibility through new boxOffset
@felixgabler
fix: Flutter 3 improvement
d22cad2
@felixgabler
feat: allow adding spacing
7306285
@felixgabler
chore: update dependencies
7c0d73d
@felixgabler
chore: remove auto-generated file from git
8952189 
should not be part of git since it contains local information
@GeekAbdelouahed GeekAbdelouahed merged commit be8eec5 into GeekAbdelouahed:master May 29, 2022
@GeekAbdelouahed
Copy link
Owner

@felixgabler Thanks a lot for your enhancements

@felixgabler
Copy link
Contributor Author

Thank you for merging! When are you planning to do the next release?

@GeekAbdelouahed
Copy link
Owner

GeekAbdelouahed commented Jun 4, 2022 •
edited

@felixgabler released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeekAbdelouahed GeekAbdelouahed GeekAbdelouahed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter 3.0.0 is detecting issue with the library Top Position isn't on top of ReactionButton
2 participants
@felixgabler @GeekAbdelouahed