Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy-branch argument does not work as expected #27

Closed
jlouros opened this issue Jul 8, 2021 · 4 comments
Closed

policy-branch argument does not work as expected #27

jlouros opened this issue Jul 8, 2021 · 4 comments
Assignees

Comments

@jlouros
Copy link

jlouros commented Jul 8, 2021

Describe the bug
Action parameter policy-branch is not working as intended. No matter what value is set, it seems to be always using the default branch.

To Reproduce
Setup action with the following params:

security-compliance:
    runs-on: ubuntu-latest
    needs:
      - codeql
    steps:
      - name: Advance Security Compliance Action
        uses: GeekMasher/advanced-security-compliance@v1.3
        with:
          token: ${{ secrets.GITHUB_PERSONAL_TOKEN }}
          policy: myTestRepo/github-actions
          policy-path: security/policies/default.yml
          policy-branch: security

Expected behavior
Action should checkout the branch defined policy-branch

Screenshots
image

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
none

@GeekMasher GeekMasher self-assigned this Jul 20, 2021
@GeekMasher
Copy link
Owner

@jlouros Thank you for sharing this and sorry for the delay. Let me check today and see if I can get a patch out ASAP.

@GeekMasher
Copy link
Owner

@jlouros You are 100% right, I added this feature all the way until the cloning stage. Thanks for reporting this.

Should be fixed in v1.4 release (today hopefully).

@GeekMasher
Copy link
Owner

@jlouros
Copy link
Author

jlouros commented Jul 20, 2021

awesome, thank you very much @GeekMasher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants