Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "conditions" for a more meaningful name #71

Closed
jmservera opened this issue Oct 26, 2022 · 2 comments
Closed

Change "conditions" for a more meaningful name #71

jmservera opened this issue Oct 26, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jmservera
Copy link

Description

As a noob I find confusing the term "conditions" because I don't know if it is a condition to fail or to pass.

Propose Solution

Instead of "ignore" and "conditions", can we find something that clearly states what will happen like allow/disallow or similar?
I understand this will cause a compatibility issue with existing license policies, but you could warn that there will be a breaking change during a time window to allow everyone to change it.

@romanoroth, @Padi-owasp

@jmservera jmservera added the enhancement New feature or request label Oct 26, 2022
@GeekMasher
Copy link
Owner

@jmservera You are absolutely right. The terms I used are not great and I think they need to be easier to understand.

This is something I want for v2 of this Action.

For reference:

  • Warnings (match == warning in the console, continues)
  • Ignores (match == skips and does not break)
  • Conditions (match == break)

@GeekMasher GeekMasher self-assigned this Oct 27, 2022
@GeekMasher
Copy link
Owner

@jmservera Closing issue, please raise all new ones in the new repo
https://github.com/advanced-security/policy-as-code/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants