Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Support for Some Languages #975

Closed
eSilverStrike opened this issue Sep 27, 2019 · 14 comments
Closed

Drop Support for Some Languages #975

eSilverStrike opened this issue Sep 27, 2019 · 14 comments
Assignees
@mystralkk
Labels
Improvement Code cleanup, Obsolete functions, or small changes to existing Features.
Milestone
2.2.2

Comments

@eSilverStrike
Copy link
Member

eSilverStrike commented Sep 27, 2019 •
edited

Some of the language files have not been translated and updated in a long time. They contain a lot of English language text.

Some language files even seem to be corrupted at some point and no one noticed like the file ukrainian_koi8-u.php for Geeklog and the Staticpages Plugin.

I think we should have a discussion about removing all language files we know are not really being used anymore?

This would include language files for the Geeklog CMS, The Core Plugins, and the Install.

I think we should keep.

English
Japanese
French
German
Hebrew

Are there any other languages we should keep?

Is this something we should do or not?
@eSilverStrike eSilverStrike added the Improvement Code cleanup, Obsolete functions, or small changes to existing Features. label Sep 27, 2019
@mystralkk
Copy link
Member

Which language does OMAL (who often posted on geeklog.net recently) and their users use?

@eSilverStrike
Copy link
Member Author

eSilverStrike commented Sep 28, 2019 •
edited

I reached out to him to find out. I guess the best thing to do would be to add an article about this and maybe a poll to figure out what languages people use and which ones we should keep. (by asking them to post in the comment section)

When we are at the point of the release candidate for Geeklog 2.2.1 and I post about it, I will add another post about the future of some of the outdated language files.

@mystralkk
Copy link
Member

That would be nice.

@eSilverStrike
Copy link
Member Author

By the way OMAL uses Japanese.

@mystralkk
Copy link
Member

I didn't know that.

@eSilverStrike eSilverStrike added this to the 2.2.1 milestone Nov 16, 2019
@eSilverStrike
Copy link
Member Author

eSilverStrike commented Nov 16, 2019 •
edited

Just added this to the 2.2.1 milestone so I remember to add a article and poll about this issue once the final release happens. Once I do that I will move this issue to a later version

@eSilverStrike eSilverStrike modified the milestones: 2.2.1, 2.2.2 Nov 21, 2019
@mystralkk
Copy link
Member

I wrote a simple script to check how much each language file is translated. Though in some entries translation might not be necessary, the results are below:

The rates of Core language files translated

LanguageRates(%)
afrikaans_utf-8.php44.2
bosnian_utf-8.php30.4
bulgarian_utf-8.php24.4
catalan_utf-8.php34.5
chinese_simplified_utf-8.php58.3
chinese_traditional_utf-8.php58.3
croatian_utf-8.php24.2
czech_utf-8.php28.7
danish_utf-8.php28.6
dutch_utf-8.php44.5
estonian_utf-8.php66.6
farsi_utf-8.php34.9
finnish_utf-8.php33.8
french_canada_utf-8.php31.1
french_france_utf-8.php65.3
german_formal_utf-8.php66.2
german_utf-8.php66.2
hebrew_utf-8.php74.4
hellenic_utf-8.php34.9
indonesian_utf-8.php31.3
italian_utf-8.php64.8
japanese_utf-8.php92.7
korean_utf-8.php47.0
norwegian_utf-8.php31.1
polish_utf-8.php45.2
portuguese_brazil_utf-8.php34.3
portuguese_utf-8.php29.4
romanian_utf-8.php24.2
russian_utf-8.php39.5
serbian_utf-8.php58.7
slovak_utf-8.php24.7
slovenian_utf-8.php61.4
spanish_argentina_utf-8.php29.5
spanish_utf-8.php46.7
swedish_utf-8.php34.1
turkish_utf-8.php43.8
ukrainian_utf-8.php47.4

The rates of calendar language files translated

LanguageRates(%)
czech_utf-8.php59.1
danish_utf-8.php58.6
dutch_utf-8.php59.1
estonian_utf-8.php82.2
french_canada_utf-8.php54.8
french_france_utf-8.php82.7
german_formal_utf-8.php81.7
german_utf-8.php81.7
hebrew_utf-8.php95.6
italian_utf-8.php81.7
japanese_utf-8.php96.2
korean_utf-8.php60.7
russian_utf-8.php60.7
slovak_utf-8.php59.6
slovenian_utf-8.php82.7
spanish_utf-8.php59.6
ukrainian_utf-8.php60.7

The rates of links language files translated

LanguageRates(%)
chinese_simplified_utf-8.php25.7
chinese_traditional_utf-8.php25.7
czech_utf-8.php25.2
dutch_utf-8.php20.1
estonian_utf-8.php89.6
french_canada_utf-8.php15.9
french_france_utf-8.php65.9
german_formal_utf-8.php72.6
german_utf-8.php72.6
hebrew_utf-8.php97.4
italian_utf-8.php88.6
japanese_utf-8.php97.4
korean_utf-8.php25.2
polish_utf-8.php24.7
russian_utf-8.php25.2
slovenian_utf-8.php90.7
spanish_utf-8.php24.2
ukrainian_utf-8.php25.2

The rates of polls language files translated

LanguageRates(%)
chinese_simplified_utf-8.php11.4
chinese_traditional_utf-8.php12.1
dutch_utf-8.php10.7
estonian_utf-8.php67.8
french_canada_utf-8.php9.2
french_france_utf-8.php76.4
german_formal_utf-8.php75.0
german_utf-8.php75.0
hebrew_utf-8.php96.4
italian_utf-8.php77.1
japanese_utf-8.php97.8
korean_utf-8.php11.4
russian_utf-8.php11.4
slovenian_utf-8.php77.1
spanish_utf-8.php12.1
ukrainian_utf-8.php12.1

The rates of recaptcha language files translated

LanguageRates(%)
french_france_utf-8.php3.3
japanese_utf-8.php70.0

The rates of spamx language files translated

LanguageRates(%)
dutch_utf-8.php77.4
estonian_utf-8.php69.5
farsi_utf-8.php5.9
french_canada_utf-8.php60.9
french_france_utf-8.php62.2
hebrew_utf-8.php88.7
italian_utf-8.php75.4
japanese_utf-8.php97.3
russian_utf-8.php69.5
slovenian_utf-8.php74.8
spanish_utf-8.php60.2
ukrainian_utf-8.php69.5

The rates of staticpages language files translated

LanguageRates(%)
chinese_simplified_utf-8.php41.7
chinese_traditional_utf-8.php41.7
czech_utf-8.php20.3
danish_utf-8.php21.3
dutch_utf-8.php35.8
estonian_utf-8.php68.4
farsi_utf-8.php39.5
french_canada_utf-8.php33.6
french_france_utf-8.php72.7
german_formal_utf-8.php77.0
german_utf-8.php77.0
hebrew_utf-8.php87.1
italian_utf-8.php73.2
japanese_utf-8.php98.3
korean_utf-8.php41.1
polish_utf-8.php38.5
portuguese_brazil_utf-8.php37.4
slovenian_utf-8.php78.0
spanish_utf-8.php34.7
swedish_utf-8.php32.0
turkish_utf-8.php33.1
ukrainian_utf-8.php41.1

The rates of xmlsitemap language files translated

LanguageRates(%)
estonian_utf-8.php57.4
french_france_utf-8.php63.8
german_formal_utf-8.php57.4
german_utf-8.php57.4
hebrew_utf-8.php65.9
italian_utf-8.php59.5
japanese_utf-8.php93.6
slovenian_utf-8.php63.8

@eSilverStrike eSilverStrike mentioned this issue Jan 28, 2020
Closed
@eSilverStrike
Copy link
Member Author

We got an updated version for the Persian Language (for Geeklog and the Core Plugins) so we should keep it as well. See #1080

So we will keep for Geeklog and the Core plugins:

English
Japanese
French
German
Hebrew
Persian

@mystralkk Any else?

I would like to keep Chinese and Spanish maybe but the translation % is not that high.

@mystralkk
Copy link
Member

It would be good to keep Chinese and Spanish since a lot of people use these languages. Similarly, Russian is a good candidate.

@eSilverStrike
Copy link
Member Author

I think that is a good selection of languages plus we have a few RTL language in there with Hebrew and Persian.

English
Japanese
French France
French Canada
German
Hebrew
Persian
Chinese Simplified
Chinese Traditional
Spanish
Russia

Do we only have the 2 character sets?

$LANG_CHARSET = 'iso-8859-1';
$LANG_CHARSET = 'utf-8';

Should we drop iso-8859-1 for most or all languages?

We should also check what happens during the upgrade and also how Geeklog handles when the site and or user accounts are set to use a language that is not available any more.

Also wondering if we should add at least a minimum supported Geeklog version number variable for each language file. This way we can warn the Admin with a message if they have a selected language that doesn't meet the min Geeklog version like we do for themes. This version number only refers to all the required language arrays are set in the file not if all the translations are complete (to prevent potential PHP errors). Figure this might be important since upgrading the old unsupported language files will be left and the Admin may not realize this. Of course this means extra work for us to update the script that synchs the language files.

Maybe combine all Lang Settings into an array while we are at.

$LANG_SETTINGS = array(
'CHARSET' => 'iso-8859-1',
'ISO639_1' => 'fr',
'gl_version' => '2.2.2' // Minimum Geeklog version language is compatible with
);

@mystralkk
Copy link
Member

Should we drop iso-8859-1 for most or all languages?

In my opinion, iso-8859-1 should be dropped since UTF-8 is its superset.

Also wondering if we should add at least a minimum supported Geeklog version number variable for each language file. This way we can warn the Admin with a message if they have a selected language that doesn't meet the min Geeklog version like we do for themes. This version number only refers to all the required language arrays are set in the file not if all the translations are complete (to prevent potential PHP errors). Figure this might be important since upgrading the old unsupported language files will be left and the Admin may not realize this. Of course this means extra work for us to update the script that synchs the language files.

Maybe combine all Lang Settings into an array while we are at.

$LANG_SETTINGS = array(
'CHARSET' => 'iso-8859-1',
'ISO639_1' => 'fr',
'gl_version' => '2.2.2' // Minimum Geeklog version language is compatible with
);

I agree. Setting up one array containing all language information is a simple and good way.

@mystralkk
Copy link
Member

@eSilverStrike Is it OK now to keep:

English
Japanese
French France
French Canada
German
Hebrew
Persian
Chinese Simplified
Chinese Traditional
Spanish
Russia

and drop all the others? Or should we wait till Geeklog 2.2.3 or later?

@eSilverStrike
Copy link
Member Author

I think so. If you have the time we might as well get it done. I guess we should cleanup the other plugin language files as well.

@mystralkk mystralkk self-assigned this Apr 4, 2022
@mystralkk
Copy link
Member

Thanks. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mystralkk mystralkk

Labels
Improvement Code cleanup, Obsolete functions, or small changes to existing Features.
Projects
None yet
Milestone
2.2.2
Development

No branches or pull requests
2 participants
@mystralkk @eSilverStrike