Fix development settings and clean import #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastellin
approved these changes
Oct 14, 2020
XaviTorello
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
It's strange, it was solved on a4ccd20#diff-35cd2b2f488742e6bc32c672d2c5f09c2a63e0e57a9a819e2ce0925013e0b59d and reintroduced on 89989e3#diff-35cd2b2f488742e6bc32c672d2c5f09c2a63e0e57a9a819e2ce0925013e0b59d
We should propose changes and review it more carefully dudes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the settings, when you try to run the dockerfile it doesn't work because the import
.basedoesn't exist.Please provide enough information so that others can review your pull request:
The import in development settings was wrong. I added a #noqa to avoid flake8 warnings.
Code formating
The code has to be well formatted following the formatting rules. For example in Python the code has to follow the PEP8.
Before create your PR, please make sure your code is formatted running:
$ >> black --exclude=venv,__pycache__ ./