Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Confirm user always receives the most up-to-date matches #19

Closed
Gelassen opened this issue Feb 21, 2023 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@Gelassen
Copy link
Owner

User story:

As a user I want to have the most relevant matches by my demand

Tech description:

The initial idea was to:
-- always polls chain by schedule or on each register demand for potential match to execute swapNoParams (= chain record, database record)
-- always pools chain by schedule for Swap event and update database records (= record in database)

However, at this moment, another solution is implemented. If you create potential match on each time when any users registers a new demand it would solve this and outdated data issues:

  • When you register a new demand there are no yet existing matches and the match table wouldn’t have a new entry. When another user register a new demand, there is a match and it would be added to the table. No duplicates.
  • When a new demand has been added and search for matches is run, there is no way the PotentialMatches table would have some of existing matches. Any new registered demand would do a whole db search for existing matches and add it to the table. As the ‘no duplicates’ issue has been solved it asserts there would not be any duplicate missed.

Potential sharding would break this schema, but at this moment it is considered as premature optimization.

This task remains open until integration test would be ready and app will pass it.

For more details please check tech documentation on GDrive.

@Gelassen
Copy link
Owner Author

Integration tests are not complete and at this moment work on them are stopped until demand in them will be rised up or I will have more resources.

Part of integration tests have been implemented and work.

@Gelassen
Copy link
Owner Author

Match are shown on 'Chain' tab.

@Gelassen
Copy link
Owner Author

Ref. #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant