Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2.13] Jadeite should support both legacy string comparison mode and unicode comparison mode #978

Open
ericwinger opened this issue Nov 18, 2022 · 5 comments
Assignees
Labels
FixInFirstCut WaitingOnRowanOrGS Issues in Jadeite that requires a fix in Rowan, GemStone or other project.

Comments

@ericwinger
Copy link
Member

Based on Dale's comments, it sounds like this option should be turned on so Jadeite can support unicode method compilation. But need to wait until Rowan is ready to support unicode.
GemTalk/Rowan#877

@ericwinger ericwinger added the enhancement New feature or request label Nov 18, 2022
@ericwinger ericwinger self-assigned this Nov 18, 2022
@ericwinger ericwinger added this to Triage in Support Rowan 3.0 via automation Nov 18, 2022
Copy link
Member

My guess is that it will be up to the user to on Unicode mode, but this is all premature … we need to understand all of the issues involved before moving forward

Copy link
Member

I am not aware of the recommendations that make when folks decide to use Unicode source in topaz … and since topaz does not automatically turn on Université comparisons I don’t think Jadeite should either

@ericwinger
Copy link
Member Author

fwiw - My simplistic tests show that nothing special needs to be done to save a method in topaz with a unicode character. So perhaps you're right that this isn't necessary (except to get around the comparison error encountered in the aforementioned comment?)

@ericwinger
Copy link
Member Author

Correction - In topaz, when the method exists, compiling it again with a unicode string requires
Unicode16 _useUnicodeComparePrimitives: true

@LisaAlmarode LisaAlmarode added FixInFirstCut and removed enhancement New feature or request labels Dec 13, 2022
@LisaAlmarode
Copy link
Member

Retitle since unicode mode became (declaratively, not verified) required for 3.2.13 while everything isn't actually working. Waiting on 3.7 server issues with GsFilein.

@LisaAlmarode LisaAlmarode added the WaitingOnRowanOrGS Issues in Jadeite that requires a fix in Rowan, GemStone or other project. label Dec 13, 2022
@LisaAlmarode LisaAlmarode changed the title Should Jadeite turn on unicode string comparisons? [3.2.13] Jadeite should support both legacy string comparison mode and unicode comparison mode Dec 13, 2022
@LisaAlmarode LisaAlmarode moved this from Triage to to-do in Support Rowan 3.0 Dec 14, 2022
@LisaAlmarode LisaAlmarode moved this from to-do to Triage in Support Rowan 3.0 Dec 14, 2022
@LisaAlmarode LisaAlmarode moved this from Triage to to-do in Support Rowan 3.0 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FixInFirstCut WaitingOnRowanOrGS Issues in Jadeite that requires a fix in Rowan, GemStone or other project.
Projects
Development

No branches or pull requests

3 participants