You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GsSessionTest>>testLogoutWhenNotLoggedIn expects an Error to be signaled if not logged in. No error is signaled, so this test fails. No other senders of #logout have handlers for this error. The fix for #11 made #logout answer true upon success, but this may not be the best answer.
It seem like it would be better to return self upon success, and signal an exception (though perhaps not an Error, perhaps a Notification?) upon an attempt to logout a not-logged-in session.
Leaving this one unfixed for now, pending design discussion.
The text was updated successfully, but these errors were encountered:
GsSessionTest>>testLogoutWhenNotLoggedIn expects an Error to be signaled if not logged in. No error is signaled, so this test fails. No other senders of #logout have handlers for this error. The fix for #11 made #logout answer true upon success, but this may not be the best answer.
It seem like it would be better to return self upon success, and signal an exception (though perhaps not an Error, perhaps a Notification?) upon an attempt to logout a not-logged-in session.
Leaving this one unfixed for now, pending design discussion.
The text was updated successfully, but these errors were encountered: