Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should GsSession>>logout signal an error if not logged in? #12

Open
martinmcclure opened this issue Aug 19, 2021 · 0 comments
Open

Should GsSession>>logout signal an error if not logged in? #12

martinmcclure opened this issue Aug 19, 2021 · 0 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@martinmcclure
Copy link
Member

GsSessionTest>>testLogoutWhenNotLoggedIn expects an Error to be signaled if not logged in. No error is signaled, so this test fails. No other senders of #logout have handlers for this error. The fix for #11 made #logout answer true upon success, but this may not be the best answer.

It seem like it would be better to return self upon success, and signal an exception (though perhaps not an Error, perhaps a Notification?) upon an attempt to logout a not-logged-in session.

Leaving this one unfixed for now, pending design discussion.

@martinmcclure martinmcclure added bug Something isn't working help wanted Extra attention is needed labels Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants