Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi, I am confused that you do not use the context in you code which is different from your paper #10

Open
bradley-code-again opened this issue Sep 21, 2023 · 1 comment

Comments

@bradley-code-again
Copy link

Hi, thanks for your wonderful sharing.
In a3c_gcn_seq2seq/net.py, method forward(...) of class Decoder, "context, attention = self.att(hidden_state, encoder_outputs, mask)", but the context is not used anywhere in the code.
From the paper, it should be used as part of the input to generate action, but in the code it is not.
I am confused on this, if you can give a bit more explanation, many thanks.

@GeminiLight
Copy link
Owner

Due to code refactoring, there is indeed a bug here. Thanks for your feedback, I'll fix it.

Repository owner deleted a comment Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants