Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_data() method fails when querying station SAUF1 #32

Closed
supermanzer opened this issue May 8, 2021 · 2 comments
Closed

get_data() method fails when querying station SAUF1 #32

supermanzer opened this issue May 8, 2021 · 2 comments
Assignees
Labels

Comments

@supermanzer
Copy link
Owner

A user has reported issues with using the get_data() function when querying the standard meteorological data URLs. The failure to receive a successful response leads to a long running loop of looking back through previous years, likely a result of the earlier fix applied to catch edge cases where the month or months being requested cross a year (e.g. getting most recent Nov, Dec, Jan, Feb).

Work done so far:

  • Validated station SAUF1 has stdmet data package and that the URLS conform to expected patterns
  • Replicated URL looping in local development environment.
@supermanzer supermanzer added the bug label May 8, 2021
@supermanzer supermanzer self-assigned this May 8, 2021
@supermanzer supermanzer added this to To do in NDBC Data Reader 1.0.0 via automation May 8, 2021
@supermanzer supermanzer moved this from To do to In progress in NDBC Data Reader 1.0.0 May 8, 2021
@supermanzer
Copy link
Owner Author

Issue appears related to station ID values that contain text characters. NDBC uses all lower case in their URLs despite using all upper case when presenting the text. This should be a simple fix, just transform whatever the user enters as station_id to a lower case string.

The looping issue is a tad more problematic. The simple answer would be to include a counter of some sort but I would rather find a solution without adding more values/variables to an already rather overloaded class. Somewhat related to #33

NDBC Data Reader 1.0.0 automation moved this from In progress to Done May 8, 2021
@vanosg
Copy link

vanosg commented May 9, 2021

Thanks for knocking this out so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants