New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Use plural for units for the other quantities #2278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnefroehlich
added
documentation
Improvements or additions to documentation
skip-changelog
Skip adding Pull Request to changelog
labels
Dec 26, 2022
yvonnefroehlich
changed the title
Use plural for units for the other quanities
WIP: Use plural for units for the other quanities
Dec 26, 2022
yvonnefroehlich
changed the title
WIP: Use plural for units for the other quanities
Use plural for units for the other quanities
Dec 26, 2022
seisman
reviewed
Dec 29, 2022
Since we may not reach a consensus about some changes and the changes are all minor, I prefer to delay this PR to v0.9.0 instead. |
seisman
approved these changes
Jan 1, 2023
seisman
added
final review call
This PR requires final review and approval from a second reviewer
and removed
needs review
This PR has higher priority and needs review.
labels
Jan 1, 2023
Ping @GenericMappingTools/pygmt-maintainers to give this PR a final review before merging. |
seisman
changed the title
Use plural for units for the other quantities
doc: Use plural for units for the other quantities
Jan 4, 2023
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
skip-changelog
Skip adding Pull Request to changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR is similar to PR #2251 and changes the units for other quanities to plural.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version