Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Use plural for units for the other quantities #2278

Merged
merged 48 commits into from Jan 4, 2023
Merged

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Dec 26, 2022

Description of proposed changes

This PR is similar to PR #2251 and changes the units for other quanities to plural.

  • documentation
  • datasets
  • tests
  • examples
    • gallery
    • tutorials
    • get started
    • projections

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Dec 26, 2022
@yvonnefroehlich yvonnefroehlich added this to the 0.8.0 milestone Dec 26, 2022
@yvonnefroehlich yvonnefroehlich changed the title Use plural for units for the other quanities WIP: Use plural for units for the other quanities Dec 26, 2022
@yvonnefroehlich
Copy link
Member Author

yvonnefroehlich commented Dec 26, 2022

I am not sure about the changes in rose.py (please see commits 9113543 and 76171ba). If singular is correct or at least sounds better, I am happy to reverse these changes.

@yvonnefroehlich yvonnefroehlich changed the title WIP: Use plural for units for the other quanities Use plural for units for the other quanities Dec 26, 2022
@yvonnefroehlich yvonnefroehlich modified the milestones: 0.8.0, 0.9.0 Dec 27, 2022
@yvonnefroehlich yvonnefroehlich modified the milestones: 0.9.0, 0.8.0 Dec 28, 2022
pygmt/src/rose.py Outdated Show resolved Hide resolved
@seisman
Copy link
Member

seisman commented Dec 29, 2022

Since we may not reach a consensus about some changes and the changes are all minor, I prefer to delay this PR to v0.9.0 instead.

@yvonnefroehlich yvonnefroehlich modified the milestones: 0.8.0, 0.9.0 Dec 29, 2022
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 1, 2023
@seisman
Copy link
Member

seisman commented Jan 3, 2023

Ping @GenericMappingTools/pygmt-maintainers to give this PR a final review before merging.

@seisman seisman changed the title Use plural for units for the other quantities doc: Use plural for units for the other quantities Jan 4, 2023
@seisman seisman merged commit c07f856 into main Jan 4, 2023
@seisman seisman deleted the fix-typos-14 branch January 4, 2023 08:52
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants