Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.grdcontour: improve the documentation of the pen parameter #2704

Closed
HouseJaay opened this issue Sep 30, 2023 · 5 comments · Fixed by #3210
Closed

Figure.grdcontour: improve the documentation of the pen parameter #2704

HouseJaay opened this issue Sep 30, 2023 · 5 comments · Fixed by #3210
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@HouseJaay
Copy link

Please describe what could be improved about this page or the typo/mistake that you found:
"pen (str) – Set pen attributes for lines or the outline of symbols."
should be:
"pen (str, list) – Set pen attributes for lines or the outline of symbols."
Because we can set pen attributes for contour lines with and without annotations separately.
Example: pen=['a0.75p,white', 'c0.25p,white'].

@welcome
Copy link

welcome bot commented Sep 30, 2023

👋 Thanks for opening your first issue here! Please make sure you filled out the template with as much detail as possible. You might also want to take a look at our contributing guidelines and code of conduct.

@yvonnefroehlich
Copy link
Member

Thanks @HouseJaay for pointing out this limitation of the docstrings 🙂!

Actually this is not only relevant for Figure.grdcontour, but also for Figure.contour.

For these two methods, I feel we should not only update the allowed input types for the pen parameter but also improve the docstring following the upstream GMT documentation instead of using the general formulation defined in the decorators.py file:

If you'd like to work on these updates, feel free to submit a pull request. For details on how contributing to PyGMT works, you may want to take a look at our Contributors Guide. Please ask any questions you have.

@yvonnefroehlich yvonnefroehlich added this to the 0.11.0 milestone Sep 30, 2023
@yvonnefroehlich yvonnefroehlich added the documentation Improvements or additions to documentation label Sep 30, 2023
@seisman seisman changed the title Suggested improvement for api/generated/pygmt.Figure.grdcontour Figure.grdcontour: Suggested improvement for api/generated/pygmt.Figure.grdcontour Oct 9, 2023
@seisman seisman modified the milestones: 0.11.0, 0.12.0 Dec 19, 2023
@seisman seisman removed this from the 0.12.0 milestone Feb 26, 2024
@seisman seisman changed the title Figure.grdcontour: Suggested improvement for api/generated/pygmt.Figure.grdcontour Figure.grdcontour: improve the documentation of the pen parameter Mar 4, 2024
@yvonnefroehlich
Copy link
Member

yvonnefroehlich commented Apr 28, 2024

What is the status on this issue? Would it be fine if I submit a PR for improving the docstring for the pen parameter for both Figure.grdcontour and Figure.contour?

@seisman
Copy link
Member

seisman commented Apr 29, 2024

Yes, please improve the docstrings following the GMT docs.

@yvonnefroehlich
Copy link
Member

Yes, please improve the docstrings following the GMT docs.

Submitted PR #3210 for this.

@seisman seisman added this to the 0.12.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants