Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support globbing patterns in .codetogether.ignore #178

Closed
brianvfernandes opened this issue Aug 6, 2020 · 1 comment
Closed

Support globbing patterns in .codetogether.ignore #178

brianvfernandes opened this issue Aug 6, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@brianvfernandes
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The .codetogether.ignore file introduced in CodeTogether 2.1 supports a general wildcard syntax to exclude resources from the shared session. However, it would be much more useful if it supported globbing patterns, like those in .gitignore

For example:

*.log
src/logfolder
src/main/*.java 

work as expected to exclude all .log files, the logfolder under the src directory and all java files under src/main folder.

However, more advanced patterns like the following do not work:

**/logs 
!important.log
debug[0-9].log
@brianvfernandes brianvfernandes added enhancement New feature or request unreviewed Pending review by development team labels Aug 6, 2020
@wgalanciak wgalanciak removed the unreviewed Pending review by development team label Aug 20, 2020
@wgalanciak wgalanciak added this to the 4.1.0 milestone Mar 24, 2021
@TimWebb TimWebb modified the milestone: 4.1.0 Jun 9, 2021
@GenuitecKanbot
Copy link
Collaborator

Happy to report this issue is resolved! (from Kanbanbot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants