Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

averages chart: no way to save DID regression results to file #409

Closed
lanselin opened this issue Apr 27, 2016 · 4 comments
Closed

averages chart: no way to save DID regression results to file #409

lanselin opened this issue Apr 27, 2016 · 4 comments

Comments

@lanselin
Copy link
Collaborator

the DID regression result interface does not have a save to file button (as the standard regression interface does). right now, there doesn't seem to be a way to save those results. in the standard regression setup, the save to file button is in the variable selection dialog, but the DID regression bypasses that dialog. so it needs to have a button on the averages chart dialog, or a right click option in the DID output window.

@lixun910
Copy link
Member

lixun910 commented May 2, 2016

Add a checkbox "Save Test Results" along with the button "Run Diff-in-Diff" test.

2 reasons for this design:

  1. Can't add this function to right click menu in regression result text, since this text control has nothing but the text result regression.
  2. All the internal variables of regression are inside the "Run Diff-in-Diff" test function, so for an easy solution, "Save Test Results" function is appended to the end of "Run Diff-in-Diff" as a check option.

The user will be prompted to save the results in external data file. (Please update the text)
screen shot 2016-05-01 at 11 02 28 pm

lixun910 referenced this issue in lixun910/geoda May 2, 2016
@lixun910 lixun910 mentioned this issue May 2, 2016
@lanselin
Copy link
Collaborator Author

lanselin commented May 4, 2016

this issue was misunderstood. there is a need to save the output of the DID regression to a text file, not the predicted values, residuals etc. the latter can always be obtained by Save Dummy and then running a standard regression on that file.

so, rather than saving to a data file, there should be a simple button: Save results to file, and ask for the name of a text file (the content of the "report").

the current save to file should be removed.

@lixun910
Copy link
Member

lixun910 commented May 4, 2016

Still keep the "Save to file" just in case the requirement of save regress results. (for future Feather interoperability)

Add a save button in print out window for saving text.
screen shot 2016-05-04 at 2 33 28 pm

@lixun910 lixun910 added this to the 1.8 milestone May 4, 2016
@lixun910 lixun910 mentioned this issue May 4, 2016
@jkoschinsky
Copy link
Collaborator

Verified in GeoDa 1.8.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants