Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legend to map #4755

Closed
jondoig opened this issue Aug 21, 2019 · 8 comments
Closed

Add legend to map #4755

jondoig opened this issue Aug 21, 2019 · 8 comments
Labels
feature A new feature to be added to the codebase

Comments

@jondoig
Copy link
Contributor

jondoig commented Aug 21, 2019

Expected Behavior

Map shows legend

Actual Behavior

No legend

Steps to Reproduce the Problem

  1. From Explore maps page, click View map for any map
  2. There is no legend to explain the symbols used in the map's layers

Specifications

@jondoig
Copy link
Contributor Author

jondoig commented Aug 21, 2019

As @afabiani pointed out, the legend is there in the TOC, but hidden by default:

image

Is it intuitive though? I didn't see it. To me that < icon is a far from intuitive symbol for expand/collapse.

Maybe set it open by default?

And reverse the direction to point right not left?

@afabiani afabiani added the feature A new feature to be added to the codebase label Aug 21, 2019
@t-book
Copy link
Contributor

t-book commented Aug 28, 2019

So from last comment of @jondoig this issue would fit better in mapsotre2 issues, right? If so (@afabiani ) can we move it?

@jondoig
Copy link
Contributor Author

jondoig commented Aug 28, 2019

Tested current useability with two other GIS/map users: same result. They couldn't find the legend, and when pointed out, agreed with my suggestions above.

@afabiani
Copy link
Member

Yes, let's open an issue to the geonode-mapstore-client repo related to this.
I would keep this open for a bit though.

@stale
Copy link

stale bot commented Oct 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Stale Bot: Stale issue label Oct 28, 2019
@jondoig
Copy link
Contributor Author

jondoig commented Oct 29, 2019

Yes, let's open an issue to the geonode-mapstore-client repo related to this.
I would keep this open for a bit though.

If I could find an issues tab on geonode-mapstore-client I'd add it there.

I reckon the main thing is to default to showing symbols for all layers.

I.e. initial view:

image

@stale stale bot removed the wontfix Stale Bot: Stale issue label Oct 29, 2019
@afabiani
Copy link
Member

@jondoig
Copy link
Contributor Author

jondoig commented Oct 30, 2019

Can close this, has been transferred to geonode-mapstore-client issue #29

@t-book t-book closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature to be added to the codebase
Projects
None yet
Development

No branches or pull requests

3 participants