Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Upgrade pinned version of pip3 #84

Open
lilatomic opened this issue May 4, 2022 · 5 comments
Open

Upgrade pinned version of pip3 #84

lilatomic opened this issue May 4, 2022 · 5 comments

Comments

@lilatomic
Copy link

pip3 is currently pinned to version 9.0.3 here, and has been for about 4 years. We should probably unpin it, or at least upgrade it.
I'm happy to submit a patch for whichever we prefer.

@t-book
Copy link
Contributor

t-book commented May 5, 2022

I do agree.

There has been a problem back in the days: 21b14c2 with an upgraded version.
before unpinning it we should test this carefully.

@frafra
Copy link

frafra commented May 5, 2022

We could implement GitHub actions to run a docker build and check for errors in advance.

@lilatomic
Copy link
Author

Right. Seems like that was a fix for #20 , where the problem was pip 10.0.0 . Seems that pip 10.0.0 changed its internals; but, since it was installed by apt but then upgraded by us, that posed problems (pip warns you about doing this, although this is the first time I've seen that actually causing issues).

I tried just removing the line to upgrade pip and use the version provided by the package manager 20.3.4. It looks like everything installed fine. In general the one installed with the package manager is a bit old (about 1.3 years) but regarded as stable.

What sorts of acceptance tests should I run to qualify the image?

Using GitHub actions to verify that it still builds is a neat idea.

@frafra
Copy link

frafra commented May 6, 2022

  1. Build test
  2. Run the image and check if the service is reachable over HTTP within a minute

Those two very simple tests that would catch the biggest regressions, in my opinion.

@giohappy
Copy link
Contributor

giohappy commented Jun 1, 2022

This repo will be aligned and upgraded soon #87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants