Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples and CI integration #193

Open
vissarion opened this issue Dec 10, 2021 · 16 comments
Open

Fix examples and CI integration #193

vissarion opened this issue Dec 10, 2021 · 16 comments

Comments

@vissarion
Copy link
Member

Is your feature request related to a problem? Please describe.
Even after the useful PR #190 some examples are still failing to compile.

Describe the solution you'd like
Some have an easy fix e.g. vpolytope-volume while some other e.g. EnvelopeProblemSOS need some work to fix the cmake (at least in my Ubuntu 20.04 with gcc version 9.3.0 I am getting an error Target "EnvelopeProblem" links to target "Python2::Python" but the target was not found after running cmake .).

Additional context
The ultimate solution would integrate all examples to be build in our CI (i.e. github actions) then we will be sure that future changes will not break them.

@Sajal193
Copy link

Hi I'd like to contribute to this. This seems to be me a very exciting repo where I can explore and develope new skills in programming. Kindly assign me this issue....

@vissarion
Copy link
Member Author

@Sajal193 thanks for your interest in the project, please go ahead and submit a PR, providing as much information as possible.

@Sajal193
Copy link

As I'm new to this tech stack, I'm acquiring data to be able to understand the issue properly and then make a PR

@Sajal193
Copy link

Thank you for considering me for the role

@Sharmalm
Copy link

Sharmalm commented Jan 9, 2022

Hi i'd like to contribute to this issue. i am new to GitHub so please guide me how to get started with this issue .
i have doubt that how i search in the codes in this repo for this issue. please explain me more about this issue

@vissarion
Copy link
Member Author

Hi i'd like to contribute to this issue. i am new to GitHub so please guide me how to get started with this issue . i have doubt that how i search in the codes in this repo for this issue. please explain me more about this issue

Thanks for your interest in the project!

Regarding getting started with github there are plenty of useful docs https://docs.github.com/en/get-started

As for this issue we essentially like to build volesti examples using github actions. If you have any specific question please let us know.

@Sharmalm
Copy link

i don't able to understand this issue .can you please elaborate how to approach solution to this problem .

@shahpratham
Copy link

I tried to fix Cmake. I wanted to ask if a new .yml file is expected to compile CMakeLists of all examples?

@vissarion
Copy link
Member Author

There is no need for a new .yml files but the current one could compile all the examples after or before compiling and executing all tests.

@Rajat1206
Copy link

I'd like to work on this issue if still possible!

@shahpratham
Copy link

Hii @vissarion. To compile CMakeList of examples/optimization_spectrahedra, we need these libraries openblas, lapack and arpack. It would be somewhat difficult to add this in github actions to install this, according to the steps mentions on how to compile.

So should I skip compiling it? Rest all examples are successfully compiling in the CI.

@himanshuParashar0101
Copy link

Hi i'd like to contribute to this issue. i have some ideas for this issue I want to try on this ,kindply please assign this issue

@shahpratham
Copy link

hey @himanshuParashar0101. I have almost completed this issue, I just wanted to ask whether to include compilation of examples/optimization_spectrahedra in github actions as it requires installation of openlas lapack and arpack.

@himanshuParashar0101
Copy link

hey @himanshuParashar0101. I have almost completed this issue, I just wanted to ask whether to include compilation of examples/optimization_spectrahedra in github actions as it requires installation of openlas lapack and arpack.

hey @himanshuParashar0101. I have almost completed this issue, I just wanted to ask whether to include compilation of examples/optimization_spectrahedra in github actions as it requires installation of openlas lapack and arpack.

yess

@adibapatel
Copy link

i would like to try my hand to this issue if possible

@vissarion
Copy link
Member Author

@adibapatel please have a look at this #265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants