Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map the presets kits to C1 or C3 #30

Closed
iurienistor opened this issue Jan 12, 2024 · 4 comments
Closed

Map the presets kits to C1 or C3 #30

iurienistor opened this issue Jan 12, 2024 · 4 comments
Labels
enhancement New feature or request implemented
Milestone

Comments

@iurienistor
Copy link
Member

Map the presets kits to C1 or C3. Request: #26

@o-bardiuk
Copy link

I mean this. Why kick drum is A4?
image

According to General Midi PERCUSSION Key Map, kick drum should be C1, and in most drum VST plugins a user expects C1 to be a kick drum.

image

@iurienistor
Copy link
Member Author

@o-bardiuk Yes, actually all the Geonkick presets need to be updated and revisited (remapping etc.). This will create incompatibilities for older projects, but... anyway, I plant to updated them. This is just loading them, modifying and save. Also, if you think you can create even a new preset and want to be included in the Geonkick factory presets... create a merge request. All the presets are under CC0 (public domain).

@iurienistor iurienistor added this to the 3.4.0 milestone Jan 19, 2024
@iurienistor iurienistor added enhancement New feature or request and removed clarify labels Jan 19, 2024
@o-bardiuk
Copy link

o-bardiuk commented Feb 2, 2024

Also, if you think you can create even a new preset and want to be included in the Geonkick factory presets... create a merge request.

Yes, I would like to do it and I know how to do it. But do Geonkick's presets include the sample part (audio) into the preset file when I save them? Or should I commit audio files too? I was going to use kick clicks for presets.

I know Serum saves single cycled waveforms into presets (fxp files) so they can take up to a few MB.

It would be cool if geonkick presets were self-contained.

UPD: It looks like you do include the sample, that's awesome!

@iurienistor
Copy link
Member Author

@o-bardiuk Yes, the audio is encoded as base64 and included into the preset file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented
Projects
None yet
Development

No branches or pull requests

2 participants