Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Search results push window width to unreasonable value #632

Closed
ocosta opened this issue Nov 7, 2023 · 3 comments
Closed

[Bug]: Search results push window width to unreasonable value #632

ocosta opened this issue Nov 7, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@ocosta
Copy link

ocosta commented Nov 7, 2023

Describe the bug

When Tuba tries to show search result cards, the window width is expanded to an unreasonable value.

Steps To Reproduce

  1. Click on search icon
  2. Search for a term (eg. "fedora")
  3. The result cards right margin go beyond the window size

Logs and/or Screenshots

<paste your logs here>

image
image
image

Instance Backend

Mastodon

Operating System

Fedora 38

Package

Flatpak

Troubleshooting information

os: GNOME 45 (Flatpak runtime)
prefix: /app
flatpak: true
version: 0.5.0 (production)
gtk: 4.12.3 (4.12.1)
libadwaita: 1.4.0 (1.4.0)
libsoup: 3.4.3 (3.4.3)
libgtksourceview: 5.10.0 (5.10.0)

Additional Context

After search results are shown, maximizing the window (super + up) still shows cropped content -- even for the search fields and menus (see screenshot). Even if you manually resize the window, it never seems to be enough, result cards are always cropped, even though there is no content demanding more horizontal space.

@ocosta ocosta added the bug Something isn't working label Nov 7, 2023
@henryrov
Copy link
Contributor

henryrov commented Nov 8, 2023

For debugging reference, with the "fedora" search in particular, this seems to be an issue with the user "deadsoul@fosstodon.org", whose status widget requests a large width and causes all other results aligned with it to expand as well. If you search for this user specifically, the same thing happens, but it behaves as expected if you search for "fedora project".

This actually seems to be an issue beyond just the search results page, as you get the same wrong behavior in the profile page if you open this user's profile.

Personally, my only guess as to what could be causing this is the user's banner picture, which has a vertical aspect ratio, but this is purely a shot in the dark, and I don't know if that could impact the search results page.

@GeopJr
Copy link
Owner

GeopJr commented Nov 8, 2023

I know what the cause of the issue is but there's nothing I can do at the moment. It depends on the ListBox => ListView migration because "fixing" it hurts performance significantly.

It has to do with LabelWithWidgets + the lines+ellipsize hack

@GeopJr
Copy link
Owner

GeopJr commented Dec 26, 2023

This specific instance has been fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants