#8 Check if parent node is a document or document fragment #9

TomCaserta · 2019-08-30T09:22:45Z

Fixes #8

codecov · 2019-08-30T09:24:40Z

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          59     60    +1     
=====================================
+ Hits           59     60    +1

Impacted Files	Coverage Δ
src/querySelectorDeep.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f5205...8325a9a. Read the comment docs.

Georgegriff

Looks great, followed the logic through on my machine and makes perfect sense. Thank you for writing a test case too!

webdriverio#8 Check if parent node is a document or document fragment

57d89c4

webdriverio#8 remove unreachable code

8325a9a

Georgegriff self-requested a review August 30, 2019 09:52

Georgegriff approved these changes Aug 30, 2019

View reviewed changes

Georgegriff merged commit 09c750d into webdriverio:master Aug 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#8 Check if parent node is a document or document fragment #9

#8 Check if parent node is a document or document fragment #9

TomCaserta commented Aug 30, 2019

codecov bot commented Aug 30, 2019 •

edited

Georgegriff left a comment

#8 Check if parent node is a document or document fragment #9

#8 Check if parent node is a document or document fragment #9

Conversation

TomCaserta commented Aug 30, 2019

codecov bot commented Aug 30, 2019 • edited

Codecov Report

Georgegriff left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 30, 2019 •

edited