Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Option to add own spacy models in constructor #69

Open
stephantul opened this issue Mar 9, 2021 · 0 comments
Open

Comments

@stephantul
Copy link

Hi,

thanks for the great package. I think it would be useful to have a constructor message that specifies the spacy model string to load (instead of a generic language attribute and a lookup).
For example, I'm currently using scispacy's en_core_sci_sm to parse text instead of en_core_web_sm. I also think en_core_web_sm might be a bad default choice, given that most of the people using quickumls might use it to parse biomedical text (although I don't have any numbers on performance).

This would also solve #68
I currently have a workaround, like this:

import spacy
from quickumls import QuickUMLS

q = QuickUMLS("my_path")
q.nlp = spacy.load("en_core_sci_sm")

I'd envision something like this:

from quickumls import QuickUMLS

q = QuickUMLS("my_path", spacy_model_string="en_core_sci_sm")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant