Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up xr_vectorize #710

Closed
MatthewJA opened this issue Nov 17, 2020 · 2 comments
Closed

Speed up xr_vectorize #710

MatthewJA opened this issue Nov 17, 2020 · 2 comments

Comments

@MatthewJA
Copy link
Contributor

MatthewJA commented Nov 17, 2020 •
edited

dea_spatialtools.xr_vectorize is seemingly orders of magnitude slower than dea_spatialtools.subpixel_contours, despite both kind of doing the same thing. I suspect this is the call to gdal/rasterio, which we can probably replace with skimage.measure.label.
@MatthewJA MatthewJA changed the title Speed up xr_rasterize Speed up xr_vectorize Nov 17, 2020
@uchchwhash
Copy link
Member

Do they return the same type of objects though?

@MatthewJA
Copy link
Contributor Author

No, but I have postprocessing code on the subpixel_contours to get them in the same format, and it's not the bottleneck as far as I can tell

@robbibt robbibt closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MatthewJA @uchchwhash @robbibt